git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-14 12:04:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

sw_engine: --compiler warning

Browse source 
../src/lib/sw_engine/tvgSwShape.cpp:232:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
  232 |         for (auto i = 0; i < dash.cnt; ++i) patternLength += pattern[i];
      |                          ~~^~~~~~~~~~
../src/lib/sw_engine/tvgSwShape.cpp:239:28: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
  239 |         for (auto i = 0; i < dash.cnt * (1 + isOdd); ++i, ++offIdx) {
This commit is contained in:
Hermet Park 2023-08-23 12:46:48 +09:00
parent cb36c25aff
commit 001c1c06fc
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lib/sw_engine/tvgSwShape.cpp
View file

@ -229,14 +229,14 @@ static SwOutline* _genDashOutline(const RenderShape* rshape, const Matrix* trans
auto patternLength = 0.0f; auto patternLength = 0.0f;
uint32_t offIdx = 0; uint32_t offIdx = 0;
if (fabsf(offset) > FLT_EPSILON) { if (fabsf(offset) > FLT_EPSILON) {
for (auto i = 0; i < dash.cnt; ++i) patternLength += pattern[i]; for (size_t i = 0; i < dash.cnt; ++i) patternLength += pattern[i];
bool isOdd = dash.cnt % 2; bool isOdd = dash.cnt % 2;
if (isOdd) patternLength *= 2; if (isOdd) patternLength *= 2;
if (offset < 0) offset = patternLength + fmod(offset, patternLength); if (offset < 0) offset = patternLength + fmod(offset, patternLength);
else offset = fmod(offset, patternLength); else offset = fmod(offset, patternLength);
for (auto i = 0; i < dash.cnt * (1 + isOdd); ++i, ++offIdx) { for (size_t i = 0; i < dash.cnt * (1 + isOdd); ++i, ++offIdx) {
auto curPattern = pattern[i % dash.cnt]; auto curPattern = pattern[i % dash.cnt];
if (offset < curPattern) break; if (offset < curPattern) break;
offset -= curPattern; offset -= curPattern;