git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-14 12:04:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

lottie/builder: revert the clipper cache.

Browse source 
This ia a buggy,
We will revisit this optimization with a perfect solution.
This commit is contained in:
Hermet Park 2023-11-24 12:19:24 +09:00
parent 3674078b31
commit 221005bb25
3 changed files with 2 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/loaders/lottie/tvgLottieBuilder.cpp
View file

@ -817,12 +817,8 @@ static void _updatePrecomp(LottieLayer* precomp, float frameNo)
//clip the layer viewport //clip the layer viewport
if (precomp->w > 0 && precomp->h > 0) { if (precomp->w > 0 && precomp->h > 0) {
if (!precomp->cache.clipper) { auto clipper = Shape::gen().release();
precomp->cache.clipper = Shape::gen().release(); clipper->appendRect(0, 0, static_cast<float>(precomp->w), static_cast<float>(precomp->h));
PP(precomp->cache.clipper)->ref();
precomp->cache.clipper->appendRect(0, 0, static_cast<float>(precomp->w), static_cast<float>(precomp->h));
}
auto clipper = precomp->cache.clipper;
clipper->transform(precomp->cache.matrix); clipper->transform(precomp->cache.matrix);
//TODO: remove the intermediate scene.... //TODO: remove the intermediate scene....

2
src/loaders/lottie/tvgLottieModel.cpp
View file

@ -156,8 +156,6 @@ LottieLayer::~LottieLayer()
delete(matte.target); delete(matte.target);
delete(transform); delete(transform);
if (cache.clipper && PP(cache.clipper)->unref() == 0) delete(cache.clipper);
} }
void LottieLayer::prepare() void LottieLayer::prepare()

3
src/loaders/lottie/tvgLottieModel.h
View file

@ -524,9 +524,6 @@ struct LottieLayer : LottieGroup
float frameNo = -1.0f; float frameNo = -1.0f;
Matrix matrix; Matrix matrix;
uint8_t opacity; uint8_t opacity;
//tvg render data
tvg::Shape* clipper = nullptr;
} cache; } cache;
Type type = Null; Type type = Null;