git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-07-04 13:45:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

api: fixed mis-aligned the ref count size, u8 -> u16

Browse source 
C++ API Modifications:
* uint8_t Paint::unref() -> uint16_t Paint::ref()
* uint8_t Paint::ref() -> uint16_t Paint::unref()
* uint8_t Paint::refCnt() -> uint16_t Paint::refCnt()

C API Modifications:
* uint8_t tvg_paint_ref(...) -> uint16_t tvg_paint_ref(...)
* uint8_t tvg_paint_unref(...) -> uint16_t tvg_paint_unref(...)
* uint8_t tvg_paint_get_ref(...) -> uint16_t tvg_paint_get_ref(...)
This commit is contained in:
Hermet Park 2025-07-02 15:21:31 +09:00
parent 74101421f9
commit 40d75c6276
5 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
inc/thorvg.h
View file

@ -506,7 +506,7 @@ public:
* *
* @since 1.0 * @since 1.0
*/ */
uint8_t ref() noexcept; uint16_t ref() noexcept;
/** /**
* @brief Decrement the reference count for the Paint instance. * @brief Decrement the reference count for the Paint instance.
@ -523,7 +523,7 @@ public:
* *
* @since 1.0 * @since 1.0
*/ */
uint8_t unref(bool free = true) noexcept; uint16_t unref(bool free = true) noexcept;
/** /**
* @brief Retrieve the current reference count of the Paint instance. * @brief Retrieve the current reference count of the Paint instance.
@ -537,7 +537,7 @@ public:
* *
* @since 1.0 * @since 1.0
*/ */
uint8_t refCnt() const noexcept; uint16_t refCnt() const noexcept;
/** /**
* @brief Returns the ID value of this class. * @brief Returns the ID value of this class.

6
src/bindings/capi/thorvg_capi.h
View file

@ -729,7 +729,7 @@ TVG_API Tvg_Result tvg_paint_del(Tvg_Paint* paint);
* *
* @since 1.0 * @since 1.0
*/ */
TVG_API uint8_t tvg_paint_ref(Tvg_Paint* paint); TVG_API uint16_t tvg_paint_ref(Tvg_Paint* paint);
/** /**
@ -748,7 +748,7 @@ TVG_API uint8_t tvg_paint_ref(Tvg_Paint* paint);
* *
* @since 1.0 * @since 1.0
*/ */
TVG_API uint8_t tvg_paint_unref(Tvg_Paint* paint, bool free); TVG_API uint16_t tvg_paint_unref(Tvg_Paint* paint, bool free);
/** /**
@ -765,7 +765,7 @@ TVG_API uint8_t tvg_paint_unref(Tvg_Paint* paint, bool free);
* *
* @since 1.0 * @since 1.0
*/ */
TVG_API uint8_t tvg_paint_get_ref(const Tvg_Paint* paint); TVG_API uint16_t tvg_paint_get_ref(const Tvg_Paint* paint);
/*! /*!

18
src/bindings/capi/tvgCapi.cpp
View file

@ -180,24 +180,24 @@ TVG_API Tvg_Result tvg_paint_del(Tvg_Paint* paint)
} }
TVG_API uint8_t tvg_paint_ref(Tvg_Paint* paint) TVG_API uint16_t tvg_paint_ref(Tvg_Paint* paint)
{ {
if (paint) return (Tvg_Result) reinterpret_cast<Paint*>(paint)->ref(); if (paint) return reinterpret_cast<Paint*>(paint)->ref();
return TVG_RESULT_INVALID_ARGUMENT; return 0;
} }
TVG_API uint8_t tvg_paint_unref(Tvg_Paint* paint, bool free) TVG_API uint16_t tvg_paint_unref(Tvg_Paint* paint, bool free)
{ {
if (paint) return (Tvg_Result) reinterpret_cast<Paint*>(paint)->unref(free); if (paint) return reinterpret_cast<Paint*>(paint)->unref(free);
return TVG_RESULT_INVALID_ARGUMENT; return 0;
} }
TVG_API uint8_t tvg_paint_get_ref(const Tvg_Paint* paint) TVG_API uint16_t tvg_paint_get_ref(const Tvg_Paint* paint)
{ {
if (paint) return (Tvg_Result) reinterpret_cast<const Paint*>(paint)->refCnt(); if (paint) return reinterpret_cast<const Paint*>(paint)->refCnt();
return TVG_RESULT_INVALID_ARGUMENT; return 0;
} }

6
src/renderer/tvgPaint.cpp
View file

@ -430,19 +430,19 @@ Result Paint::blend(BlendMethod method) noexcept
} }
uint8_t Paint::ref() noexcept uint16_t Paint::ref() noexcept
{ {
return pImpl->ref(); return pImpl->ref();
} }
uint8_t Paint::unref(bool free) noexcept uint16_t Paint::unref(bool free) noexcept
{ {
return pImpl->unrefx(free); return pImpl->unrefx(free);
} }
uint8_t Paint::refCnt() const noexcept uint16_t Paint::refCnt() const noexcept
{ {
return pImpl->refCnt; return pImpl->refCnt;
} }

6
src/renderer/tvgPaint.h
View file

@ -106,18 +106,18 @@ namespace tvg
} }
} }
uint8_t ref() uint16_t ref()
{ {
return ++refCnt; return ++refCnt;
} }
uint8_t unref(bool free = true) uint16_t unref(bool free = true)
{ {
parent = nullptr; parent = nullptr;
return unrefx(free); return unrefx(free);
} }
uint8_t unrefx(bool free) uint16_t unrefx(bool free)
{ {
if (refCnt > 0) --refCnt; if (refCnt > 0) --refCnt;