git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-12 15:34:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

lottie: rectified scene building Logic

Browse source 
resolved a corner case where assets were being attached
multiple times during scene building. This issue was causing
a significant performence drop in image animation
in certain scenarios.
This commit is contained in:
Hermet Park 2024-01-25 01:31:41 +09:00 • committed by Hermet Park
parent be809b2103
commit 823b945666
5 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/examples/resources/11555.json Normal file
View file

File diff suppressed because one or more lines are too long

1
src/examples/resources/loading_siri.json
View file

File diff suppressed because one or more lines are too long

2
src/loaders/lottie/tvgLottieBuilder.cpp
View file

@ -1091,6 +1091,8 @@ static void _attachFont(LottieComposition* comp, LottieLayer* parent)
static bool _buildComposition(LottieComposition* comp, LottieGroup* parent) static bool _buildComposition(LottieComposition* comp, LottieGroup* parent)
{ {
if (parent->children.count == 0) return false; if (parent->children.count == 0) return false;
if (parent->buildDone) return true;
parent->buildDone = true;
for (auto c = parent->children.data; c < parent->children.end(); ++c) { for (auto c = parent->children.data; c < parent->children.end(); ++c) {
auto child = static_cast<LottieLayer*>(*c); auto child = static_cast<LottieLayer*>(*c);

1
src/loaders/lottie/tvgLottieModel.h
View file

@ -531,6 +531,7 @@ struct LottieGroup : LottieObject
Array<LottieObject*> children; Array<LottieObject*> children;
bool reqFragment = false; //requirment to fragment the render context bool reqFragment = false; //requirment to fragment the render context
bool buildDone = false; //completed in building the composition.
}; };

8
src/renderer/sw_engine/tvgSwRasterTexmap.h
View file

@ -528,8 +528,8 @@ static void _rasterPolygonImageSegment(SwSurface* surface, const SwImage* image,
vv = (int) v; vv = (int) v;
if (vv >= sh) continue; if (vv >= sh) continue;
ar = (int)(255 * (1 - modff(u, &iptr))); ar = (int)(255.0f * (1.0f - modff(u, &iptr)));
ab = (int)(255 * (1 - modff(v, &iptr))); ab = (int)(255.0f * (1.0f - modff(v, &iptr)));
iru = uu + 1; iru = uu + 1;
irv = vv + 1; irv = vv + 1;
@ -576,8 +576,8 @@ static void _rasterPolygonImageSegment(SwSurface* surface, const SwImage* image,
uu = (int) u; uu = (int) u;
vv = (int) v; vv = (int) v;
ar = (int)(255 * (1 - modff(u, &iptr))); ar = (int)(255.0f * (1.0f - modff(u, &iptr)));
ab = (int)(255 * (1 - modff(v, &iptr))); ab = (int)(255.0f * (1.0f - modff(v, &iptr)));
iru = uu + 1; iru = uu + 1;
irv = vv + 1; irv = vv + 1;