git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-13 11:36:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

gl_engine: Fix memory leak caused by no deleted GlRenderTask

Browse source
This commit is contained in:
RuiwenTang 2024-06-24 21:51:49 +08:00 • committed by Hermet Park
parent 376acfacdb
commit 95dde5807e
3 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/renderer/gl_engine/tvgGlRenderTask.cpp
View file

@ -259,6 +259,12 @@ void GlDrawBlitTask::run()
GlClipTask::GlClipTask(GlRenderTask* clip, GlRenderTask* mask) GlClipTask::GlClipTask(GlRenderTask* clip, GlRenderTask* mask)
:GlRenderTask(nullptr), mClipTask(clip), mMaskTask(mask) {} :GlRenderTask(nullptr), mClipTask(clip), mMaskTask(mask) {}
GlClipTask::~GlClipTask()
{
delete mClipTask;
delete mMaskTask;
}
void GlClipTask::run() void GlClipTask::run()
{ {
GL_CHECK(glEnable(GL_STENCIL_TEST)); GL_CHECK(glEnable(GL_STENCIL_TEST));

2
src/renderer/gl_engine/tvgGlRenderTask.h
View file

@ -169,7 +169,7 @@ class GlClipTask : public GlRenderTask
{ {
public: public:
GlClipTask(GlRenderTask* clip, GlRenderTask* mask); GlClipTask(GlRenderTask* clip, GlRenderTask* mask);
~GlClipTask() override = default; ~GlClipTask() override;
void run() override; void run() override;

5
src/renderer/gl_engine/tvgGlRenderer.cpp
View file

@ -567,7 +567,10 @@ void GlRenderer::drawPrimitive(GlShape& sdata, uint8_t r, uint8_t g, uint8_t b,
auto task = new GlRenderTask(mPrograms[RT_Color].get()); auto task = new GlRenderTask(mPrograms[RT_Color].get());
task->setDrawDepth(depth); task->setDrawDepth(depth);
if (!sdata.geometry->draw(task, mGpuBuffer.get(), flag)) return; if (!sdata.geometry->draw(task, mGpuBuffer.get(), flag)) {
delete task;
return;
}
GlRenderTask* stencilTask = nullptr; GlRenderTask* stencilTask = nullptr;