From a1ffa039bb8bd44b3334f66fbd15cd57151c61e3 Mon Sep 17 00:00:00 2001 From: JunsuChoi Date: Wed, 24 Apr 2024 20:47:29 +0900 Subject: [PATCH] loader/svg: If link string is empty, not create picture object An empty link causes the wrong loader to be found and causes various problems. related issue : https://github.com/thorvg/thorvg/issues/2078#issuecomment-2067726046 --- src/loaders/svg/tvgSvgSceneBuilder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loaders/svg/tvgSvgSceneBuilder.cpp b/src/loaders/svg/tvgSvgSceneBuilder.cpp index e6ee4d3d..b61227d6 100644 --- a/src/loaders/svg/tvgSvgSceneBuilder.cpp +++ b/src/loaders/svg/tvgSvgSceneBuilder.cpp @@ -557,7 +557,7 @@ static bool _isValidImageMimeTypeAndEncoding(const char** href, const char** mim static unique_ptr _imageBuildHelper(SvgLoaderData& loaderData, SvgNode* node, const Box& vBox, const string& svgPath) { - if (!node->node.image.href) return nullptr; + if (!node->node.image.href || !strlen(node->node.image.href)) return nullptr; auto picture = Picture::gen(); TaskScheduler::async(false); //force to load a picture on the same thread