git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-14 12:04:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

lottie: enhance parsing of position's SeparateCoords

Browse source 
The "s" key does not have to appear at the beginning
of the position block. Previously, such cases would
result in a parsing error — now they are handled correctly.
This commit is contained in:
Mira Grudzinska 2025-05-06 22:15:35 +02:00 • committed by Hermet Park
parent a21ecdc1ae
commit a6898ccf42
2 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/loaders/lottie/tvgLottieModel.h
View file

@ -553,6 +553,12 @@ struct LottieTransform : LottieObject
LottieFloat y = 0.0f; LottieFloat y = 0.0f;
}; };
SeparateCoord* separateCoord()
{
if (!coords) coords = new SeparateCoord;
return coords;
}
struct RotationEx struct RotationEx
{ {
LottieFloat x = 0.0f; LottieFloat x = 0.0f;

13
src/loaders/lottie/tvgLottieParser.cpp
View file

@ -603,11 +603,14 @@ LottieTransform* LottieParser::parseTransform(bool ddd)
enterObject(); enterObject();
while (auto key = nextObjectKey()) { while (auto key = nextObjectKey()) {
if (KEY_AS("k")) parsePropertyInternal(transform->position); if (KEY_AS("k")) parsePropertyInternal(transform->position);
else if (KEY_AS("s") && getBool()) transform->coords = new LottieTransform::SeparateCoord; else if (KEY_AS("x"))
//check separateCoord to figure out whether "x(expression)" / "x(coord)" {
else if (transform->coords && KEY_AS("x")) parseProperty<LottieProperty::Type::Float>(transform->coords->x); //check separateCoord to figure out whether "x(expression)" / "x(coord)"
else if (transform->coords && KEY_AS("y")) parseProperty<LottieProperty::Type::Float>(transform->coords->y); if (peekType() == kStringType) transform->position.exp = _expression(getStringCopy(), comp, context.layer, context.parent, &transform->position);
else if (KEY_AS("x")) transform->position.exp = _expression(getStringCopy(), comp, context.layer, context.parent, &transform->position); else parseProperty(transform->separateCoord()->x);
}
else if (KEY_AS("y")) parseProperty(transform->separateCoord()->y);
else if (KEY_AS("sid")) registerSlot<LottieProperty::Type::Position>(transform, getString()); else if (KEY_AS("sid")) registerSlot<LottieProperty::Type::Position>(transform, getString());
else skip(key); else skip(key);
} }