From a6985047149d081ecf0c5b3265b489c3e937a9d4 Mon Sep 17 00:00:00 2001 From: Hermet Park Date: Wed, 18 Jun 2025 15:43:22 +0900 Subject: [PATCH] renderer: rectify the update flag once more - image tag is a bit ambuguous for vector type picture - engine doesn't need to take care of the none flag update because renderer filters that case. --- src/renderer/gl_engine/tvgGlRenderer.cpp | 4 ---- src/renderer/sw_engine/tvgSwRenderer.cpp | 2 -- src/renderer/tvgAnimation.cpp | 2 +- src/renderer/wg_engine/tvgWgRenderer.cpp | 4 ---- 4 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/renderer/gl_engine/tvgGlRenderer.cpp b/src/renderer/gl_engine/tvgGlRenderer.cpp index b3721f74..b26ef8ca 100644 --- a/src/renderer/gl_engine/tvgGlRenderer.cpp +++ b/src/renderer/gl_engine/tvgGlRenderer.cpp @@ -1381,8 +1381,6 @@ static GLuint _genTexture(RenderSurface* image) RenderData GlRenderer::prepare(RenderSurface* image, RenderData data, const Matrix& transform, Array& clips, uint8_t opacity, RenderUpdateFlag flags) { - if (flags == RenderUpdateFlag::None) return data; - auto sdata = static_cast(data); if (!sdata) sdata = new GlShape; @@ -1415,8 +1413,6 @@ RenderData GlRenderer::prepare(RenderSurface* image, RenderData data, const Matr RenderData GlRenderer::prepare(const RenderShape& rshape, RenderData data, const Matrix& transform, Array& clips, uint8_t opacity, RenderUpdateFlag flags, bool clipper) { - if (flags == RenderUpdateFlag::None) return data; - // If prepare for clip, only path is meaningful. if (clipper) flags = RenderUpdateFlag::Path; diff --git a/src/renderer/sw_engine/tvgSwRenderer.cpp b/src/renderer/sw_engine/tvgSwRenderer.cpp index 3be52319..f77f4216 100644 --- a/src/renderer/sw_engine/tvgSwRenderer.cpp +++ b/src/renderer/sw_engine/tvgSwRenderer.cpp @@ -727,7 +727,6 @@ void* SwRenderer::prepareCommon(SwTask* task, const Matrix& transform, const Arr RenderData SwRenderer::prepare(RenderSurface* surface, RenderData data, const Matrix& transform, Array& clips, uint8_t opacity, RenderUpdateFlag flags) { - //prepare task auto task = static_cast(data); if (task) task->done(); else { @@ -741,7 +740,6 @@ RenderData SwRenderer::prepare(RenderSurface* surface, RenderData data, const Ma RenderData SwRenderer::prepare(const RenderShape& rshape, RenderData data, const Matrix& transform, Array& clips, uint8_t opacity, RenderUpdateFlag flags, bool clipper) { - //prepare task auto task = static_cast(data); if (task) task->done(); else { diff --git a/src/renderer/tvgAnimation.cpp b/src/renderer/tvgAnimation.cpp index 6d4d0bff..94be354e 100644 --- a/src/renderer/tvgAnimation.cpp +++ b/src/renderer/tvgAnimation.cpp @@ -43,7 +43,7 @@ Result Animation::frame(float no) noexcept if (!loader->animatable()) return Result::NonSupport; if (static_cast(loader)->frame(no)) { - PAINT(pImpl->picture)->mark(RenderUpdateFlag::Image); + PAINT(pImpl->picture)->mark(RenderUpdateFlag::All); return Result::Success; } return Result::InsufficientCondition; diff --git a/src/renderer/wg_engine/tvgWgRenderer.cpp b/src/renderer/wg_engine/tvgWgRenderer.cpp index 6f8c937e..9b250782 100644 --- a/src/renderer/wg_engine/tvgWgRenderer.cpp +++ b/src/renderer/wg_engine/tvgWgRenderer.cpp @@ -131,8 +131,6 @@ bool WgRenderer::surfaceConfigure(WGPUSurface surface, WgContext& context, uint3 RenderData WgRenderer::prepare(const RenderShape& rshape, RenderData data, const Matrix& transform, Array& clips, uint8_t opacity, RenderUpdateFlag flags, bool clipper) { - if (flags == RenderUpdateFlag::None) return data; - auto renderDataShape = data ? (WgRenderDataShape*)data : mRenderDataShapePool.allocate(mContext); // update geometry @@ -164,8 +162,6 @@ RenderData WgRenderer::prepare(const RenderShape& rshape, RenderData data, const RenderData WgRenderer::prepare(RenderSurface* surface, RenderData data, const Matrix& transform, Array& clips, uint8_t opacity, RenderUpdateFlag flags) { - if (flags == RenderUpdateFlag::None) return data; - auto renderDataPicture = data ? (WgRenderDataPicture*)data : mRenderDataPicturePool.allocate(mContext); // update paint settings