git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-14 12:04:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

wasm: Enhance gif saving without data copy

Browse source 
Removed data copy for gif saving.

Binding function `save` has changed:
- bool save(string data, string mimetype)
This commit is contained in:
Jinny You 2024-11-18 13:31:44 +09:00 • committed by Hermet Park
parent a5dc165fa8
commit a85470b5d5
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/bindings/wasm/tvgWasmLottieAnimation.cpp
View file

@ -230,9 +230,6 @@ public:
return false; return false;
} }
//FIXME: remove this copy, save with a file passing.
this->data = data; //back up for saving
canvas->clear(true); canvas->clear(true);
delete(animation); delete(animation);
@ -350,15 +347,15 @@ public:
} }
// Saver methods // Saver methods
bool save(string mimetype) bool save(string data, string mimetype)
{ {
if (mimetype == "gif") return save2Gif(); if (mimetype == "gif") return save2Gif(data);
errorMsg = "Invalid mimetype"; errorMsg = "Invalid mimetype";
return false; return false;
} }
bool save2Gif() bool save2Gif(string data)
{ {
errorMsg = NoError; errorMsg = NoError;
@ -427,7 +424,6 @@ private:
Canvas* canvas = nullptr; Canvas* canvas = nullptr;
Animation* animation = nullptr; Animation* animation = nullptr;
TvgEngineMethod* engine = nullptr; TvgEngineMethod* engine = nullptr;
string data;
uint32_t width = 0; uint32_t width = 0;
uint32_t height = 0; uint32_t height = 0;
float psize[2]; //picture size float psize[2]; //picture size