git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-16 21:15:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

svg_loader: initializing uninitialized variables

Browse source 
The 'loader->svgParse->global' variable was uninitialized when no viewBox attribute
was set. If gradient was applied, the division by zero occured and no gradient was drawn.
This commit is contained in:
Mira Grudzinska 2021-06-07 00:14:37 +02:00 • committed by JunsuChoi
parent 73ea4abf51
commit ae5673658e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/loaders/svg/tvgSvgLoader.cpp
View file

@ -1069,9 +1069,15 @@ static SvgNode* _createSvgNode(SvgLoaderData* loader, SvgNode* parent, const cha
if (!loader->svgParse->node) return nullptr; if (!loader->svgParse->node) return nullptr;
SvgDocNode* doc = &(loader->svgParse->node->node.doc); SvgDocNode* doc = &(loader->svgParse->node->node.doc);
loader->svgParse->global.w = 0;
loader->svgParse->global.h = 0;
doc->preserveAspect = true; doc->preserveAspect = true;
simpleXmlParseAttributes(buf, bufLength, _attrParseSvgNode, loader); simpleXmlParseAttributes(buf, bufLength, _attrParseSvgNode, loader);
if (loader->svgParse->global.w == 0) loader->svgParse->global.w = loader->svgParse->node->node.doc.w;
if (loader->svgParse->global.h == 0) loader->svgParse->global.h = loader->svgParse->node->node.doc.h;
return loader->svgParse->node; return loader->svgParse->node;
} }