git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-10 06:34:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

svg_loader: memory leak after improper stop tag

Browse source 
<stop> tag should be always a child of a <linearGradient> or
<radialGradient> element, but there were files with <stop> tag inside <rect>.
This patch fixes a memory leak if no gradient is defined before <stop> tag.
This commit is contained in:
Michal Maciola 2021-07-01 12:32:28 +02:00 • committed by Hermet Park
parent 935b8592f1
commit b005f97bcd
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/loaders/svg/tvgSvgLoader.cpp
View file

@ -2232,15 +2232,19 @@ static void _svgLoaderParserXmlOpen(SvgLoaderData* loader, const char* content,
}
loader->latestGradient = gradient;
} else if (!strcmp(tagName, "stop")) {
if (!loader->latestGradient) {
#ifdef THORVG_LOG_ENABLED
printf("SVG: Gradient stop but no gradient in the scope\n");
#endif
return;
}
auto stop = static_cast<Fill::ColorStop*>(calloc(1, sizeof(Fill::ColorStop)));
if (!stop) return;
loader->svgParse->gradStop = stop;
/* default value for opacity */
stop->a = 255;
simpleXmlParseAttributes(attrs, attrsLength, _attrParseStops, loader);
if (loader->latestGradient) {
loader->latestGradient->stops.push(stop);
}
loader->latestGradient->stops.push(stop);
}
#ifdef THORVG_LOG_ENABLED
else {