git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-13 11:36:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

sw_engine: fix memory leak.

Browse source 
free resources properly at exceptional case.
This commit is contained in:
Hermet Park 2020-09-07 17:40:39 +09:00
parent 0f07054924
commit d4fce27909
1 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/lib/sw_engine/tvgSwShape.cpp
View file

@ -618,7 +618,9 @@ void shapeResetStroke(SwShape* shape, const Shape* sdata, const Matrix* transfor
bool shapeGenStrokeRle(SwShape* shape, const Shape* sdata, const Matrix* transform, const SwSize& clip)
{
SwOutline* shapeOutline = nullptr;
SwOutline* strokeOutline = nullptr;
bool freeOutline = false;
bool ret = true;
//Dash Style Stroke
if (sdata->strokeDash(nullptr) > 0) {
@ -633,22 +635,32 @@ bool shapeGenStrokeRle(SwShape* shape, const Shape* sdata, const Matrix* transfo
shapeOutline = shape->outline;
}
if (!strokeParseOutline(shape->stroke, *shapeOutline)) return false;
if (!strokeParseOutline(shape->stroke, *shapeOutline)) {
ret = false;
goto fail;
}
auto strokeOutline = strokeExportOutline(shape->stroke);
if (!strokeOutline) return false;
strokeOutline = strokeExportOutline(shape->stroke);
if (!strokeOutline) {
ret = false;
goto fail;
}
SwBBox bbox;
_updateBBox(strokeOutline, bbox);
if (!_checkValid(strokeOutline, bbox, clip)) return false;
if (!_checkValid(strokeOutline, bbox, clip)) {
ret = false;
goto fail;
}
shape->strokeRle = rleRender(strokeOutline, bbox, clip, true);
fail:
if (freeOutline) _delOutline(shapeOutline);
_delOutline(strokeOutline);
return true;
return ret;
}