From e737ee4a4f8e13ce284a30d5d82457213e13d3b0 Mon Sep 17 00:00:00 2001 From: Hermet Park Date: Tue, 22 Dec 2020 11:03:13 +0900 Subject: [PATCH] svg_loader: fixed wrong boundary check sz must be less than 20 to append 'carriage return' --- src/loaders/svg/tvgSvgLoader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/loaders/svg/tvgSvgLoader.cpp b/src/loaders/svg/tvgSvgLoader.cpp index 16017160..e421c392 100644 --- a/src/loaders/svg/tvgSvgLoader.cpp +++ b/src/loaders/svg/tvgSvgLoader.cpp @@ -2124,7 +2124,7 @@ static void _svgLoaderParserXmlOpen(SvgLoaderData* loader, const char* content, sz = attrs - content; attrsLength = length - sz; while ((sz > 0) && (isspace(content[sz - 1]))) sz--; - if ((unsigned int)sz >= sizeof(tagName)) return; + if ((uint)sz >= sizeof(tagName)) return; strncpy(tagName, content, sz); tagName[sz] = '\0'; } @@ -2486,7 +2486,7 @@ static bool _svgLoaderParserForValidCheckXmlOpen(SvgLoaderData* loader, const ch sz = attrs - content; attrsLength = length - sz; while ((sz > 0) && (isspace(content[sz - 1]))) sz--; - if ((unsigned int)sz > sizeof(tagName)) return false; + if ((uint)sz >= sizeof(tagName)) return false; strncpy(tagName, content, sz); tagName[sz] = '\0'; }