git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-08 13:43:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

common render: removed unnecessary assignments in update() fun

Browse source 
The rotation part of the transformation matrix can be assigned,
it does not have to be multiplied by the identity matrix.
The values of e13 and e23 of the transformation matrix represents the translation,
so they don't need to be taken into account in the rotation part.
This commit is contained in:
Mira Grudzinska 2021-02-01 01:33:50 +01:00 • committed by Hermet Park
parent e5f59b53a4
commit f1fd23cf32
1 changed files with 9 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/lib/tvgRender.cpp
View file

@ -68,8 +68,8 @@ bool RenderTransform::update()
m.e33 = 1.0f;
//scale
m.e11 *= scale;
m.e22 *= scale;
m.e11 = scale;
m.e22 = scale;
//rotation
if (fabsf(degree) > FLT_EPSILON) {
@ -77,23 +77,14 @@ bool RenderTransform::update()
auto cosVal = cosf(radian);
auto sinVal = sinf(radian);
auto t11 = m.e11 * cosVal + m.e12 * sinVal;
auto t12 = m.e11 * -sinVal + m.e12 * cosVal;
auto t21 = m.e21 * cosVal + m.e22 * sinVal;
auto t22 = m.e21 * -sinVal + m.e22 * cosVal;
auto t13 = m.e13 * cosVal + m.e23 * sinVal;
auto t23 = m.e13 * -sinVal + m.e23 * cosVal;
m.e11 = t11;
m.e12 = t12;
m.e21 = t21;
m.e22 = t22;
m.e13 = t13;
m.e23 = t23;
m.e12 = m.e11 * -sinVal;
m.e11 *= cosVal;
m.e21 = m.e22 * sinVal;
m.e22 *= cosVal;
}
m.e13 += x;
m.e23 += y;
m.e13 = x;
m.e23 = y;
return true;
}
@ -117,4 +108,4 @@ RenderTransform::RenderTransform(const RenderTransform* lhs, const RenderTransfo
m.e31 = lhs->m.e31 * rhs->m.e11 + lhs->m.e32 * rhs->m.e21 + lhs->m.e33 * rhs->m.e31;
m.e32 = lhs->m.e31 * rhs->m.e12 + lhs->m.e32 * rhs->m.e22 + lhs->m.e33 * rhs->m.e32;
m.e33 = lhs->m.e31 * rhs->m.e13 + lhs->m.e32 * rhs->m.e23 + lhs->m.e33 * rhs->m.e33;
}
}