git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-08 05:33:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

common gradient: Fix possible crash in color setter

Browse source 
Memcpy is not allowed on nullptr. If colorStops is invalid colors are
cleared.
This commit is contained in:
Michal Szczecinski 2021-06-04 13:24:29 +02:00 • committed by Hermet Park
parent 718578532c
commit f8b636d4d0
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lib/tvgFill.cpp
View file

@ -43,11 +43,13 @@ Fill::~Fill()
Result Fill::colorStops(const ColorStop* colorStops, uint32_t cnt) noexcept Result Fill::colorStops(const ColorStop* colorStops, uint32_t cnt) noexcept
{ {
if ((!colorStops && cnt > 0) || (colorStops && cnt == 0)) return Result::InvalidArguments;
if (cnt == 0) { if (cnt == 0) {
if (pImpl->colorStops) { if (pImpl->colorStops) {
free(pImpl->colorStops); free(pImpl->colorStops);
pImpl->colorStops = nullptr; pImpl->colorStops = nullptr;
pImpl->cnt = cnt; pImpl->cnt = 0;
} }
return Result::Success; return Result::Success;
} }