mirror of
https://github.com/thorvg/thorvg.git
synced 2025-06-19 14:31:39 +00:00
0394fa5ef5
Paints must clear canvas engine data if they were dismissed from the canvas, 1. Canvas::clear(free = false) must retain all the paints from the paints hierarchy so that user keeps the all dangled paints lifecycle. In this scenario, it could leak the engine data of paints, this patch fixes it. 2. Previously, t just keeps the immediate paints lives of canvas, but not them of children of scene nor picture. This patch changes a policy which was not considered seriously, Now it keeps the all paints lives through the tree-hieararchy. 3. Also changed the Scene::clear() behavior identical to Canvas::clear() for consistency. @API Modification: From: Result Scene::clear() noexcept; To: Result Scene::clear(bool free = true) noexcept;
114 lines
3.5 KiB
C
114 lines
3.5 KiB
C
/*
|
|
* Copyright (c) 2020-2021 Samsung Electronics Co., Ltd. All rights reserved.
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
* The above copyright notice and this permission notice shall be included in all
|
|
* copies or substantial portions of the Software.
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*/
|
|
#ifndef _TVG_CANVAS_IMPL_H_
|
|
#define _TVG_CANVAS_IMPL_H_
|
|
|
|
#include "tvgPaint.h"
|
|
|
|
/************************************************************************/
|
|
/* Internal Class Implementation */
|
|
/************************************************************************/
|
|
|
|
struct Canvas::Impl
|
|
{
|
|
Array<Paint*> paints;
|
|
RenderMethod* renderer;
|
|
bool refresh = false; //if all paints should be updated by force.
|
|
|
|
Impl(RenderMethod* pRenderer):renderer(pRenderer)
|
|
{
|
|
}
|
|
|
|
~Impl()
|
|
{
|
|
clear(true);
|
|
delete(renderer);
|
|
}
|
|
|
|
Result push(unique_ptr<Paint> paint)
|
|
{
|
|
auto p = paint.release();
|
|
if (!p) return Result::MemoryCorruption;
|
|
paints.push(p);
|
|
|
|
return update(p, true);
|
|
}
|
|
|
|
Result clear(bool free)
|
|
{
|
|
//Clear render target before drawing
|
|
if (!renderer || !renderer->clear()) return Result::InsufficientCondition;
|
|
|
|
//free paints
|
|
for (auto paint = paints.data; paint < (paints.data + paints.count); ++paint) {
|
|
(*paint)->pImpl->dispose(*renderer);
|
|
if (free) delete(*paint);
|
|
}
|
|
|
|
paints.clear();
|
|
|
|
return Result::Success;
|
|
}
|
|
|
|
void needRefresh()
|
|
{
|
|
refresh = true;
|
|
}
|
|
|
|
Result update(Paint* paint, bool force)
|
|
{
|
|
if (!renderer) return Result::InsufficientCondition;
|
|
|
|
Array<RenderData> clips;
|
|
auto flag = RenderUpdateFlag::None;
|
|
if (refresh || force) flag = RenderUpdateFlag::All;
|
|
|
|
//Update single paint node
|
|
if (paint) {
|
|
paint->pImpl->update(*renderer, nullptr, 255, clips, flag);
|
|
//Update all retained paint nodes
|
|
} else {
|
|
for (auto paint = paints.data; paint < (paints.data + paints.count); ++paint) {
|
|
(*paint)->pImpl->update(*renderer, nullptr, 255, clips, flag);
|
|
}
|
|
}
|
|
|
|
refresh = false;
|
|
|
|
return Result::Success;
|
|
}
|
|
|
|
Result draw()
|
|
{
|
|
if (!renderer || !renderer->preRender()) return Result::InsufficientCondition;
|
|
|
|
for (auto paint = paints.data; paint < (paints.data + paints.count); ++paint) {
|
|
if (!(*paint)->pImpl->render(*renderer)) return Result::InsufficientCondition;
|
|
}
|
|
|
|
if (!renderer->postRender()) return Result::InsufficientCondition;
|
|
|
|
return Result::Success;
|
|
}
|
|
};
|
|
|
|
#endif /* _TVG_CANVAS_IMPL_H_ */
|