lottie: improve the compatiblity

merge the scene with more accurate condition to allow
the evenodd pathes among the lottie render tree.
This commit is contained in:
Hermet Park 2025-03-27 13:11:57 +09:00 committed by Mira Grudzinska
parent 4e5ff3ea9a
commit 558a9991de
4 changed files with 20 additions and 16 deletions

View file

@ -167,12 +167,8 @@ void LottieBuilder::updateTransform(LottieLayer* layer, float frameNo)
_updateTransform(transform, frameNo, layer->autoOrient, matrix, layer->cache.opacity, exps);
if (parent) {
if (!identity((const Matrix*) &parent->cache.matrix)) {
if (identity((const Matrix*) &matrix)) layer->cache.matrix = parent->cache.matrix;
else layer->cache.matrix = parent->cache.matrix * matrix;
}
}
if (parent) layer->cache.matrix = parent->cache.matrix * matrix;
layer->cache.frameNo = frameNo;
}
@ -182,25 +178,30 @@ void LottieBuilder::updateTransform(LottieGroup* parent, LottieObject** child, f
auto transform = static_cast<LottieTransform*>(*child);
if (!transform) return;
Matrix m;
uint8_t opacity;
if (parent->mergeable()) {
if (!ctx->transform) ctx->transform = (Matrix*)malloc(sizeof(Matrix));
if (ctx->transform) {
_updateTransform(transform, frameNo, false, m, opacity, exps);
*ctx->transform *= m;
} else {
ctx->transform = new Matrix;
_updateTransform(transform, frameNo, false, *ctx->transform, opacity, exps);
}
return;
}
ctx->merging = nullptr;
Matrix matrix;
if (!_updateTransform(transform, frameNo, false, matrix, opacity, exps)) return;
if (!_updateTransform(transform, frameNo, false, m, opacity, exps)) return;
ctx->propagator->transform(PP(ctx->propagator)->transform() * matrix);
ctx->propagator->transform(PP(ctx->propagator)->transform() * m);
ctx->propagator->opacity(MULTIPLY(opacity, PP(ctx->propagator)->opacity));
//FIXME: preserve the stroke width. too workaround, need a better design.
if (P(ctx->propagator)->rs.strokeWidth() > 0.0f) {
auto denominator = sqrtf(matrix.e11 * matrix.e11 + matrix.e12 * matrix.e12);
auto denominator = sqrtf(m.e11 * m.e11 + m.e12 * m.e12);
if (denominator > 1.0f) ctx->propagator->stroke(ctx->propagator->strokeWidth() / denominator);
}
}

View file

@ -71,7 +71,7 @@ struct RenderContext
~RenderContext()
{
PP(propagator)->unref();
free(transform);
delete(transform);
delete(roundness);
delete(offsetPath);
}
@ -84,6 +84,10 @@ struct RenderContext
this->repeaters = rhs.repeaters;
if (rhs.roundness) this->roundness = new LottieRoundnessModifier(rhs.roundness->r);
if (rhs.offsetPath) this->offsetPath = new LottieOffsetModifier(rhs.offsetPath->offset, rhs.offsetPath->miterLimit, rhs.offsetPath->join);
if (rhs.transform) {
transform = new Matrix;
*transform = *rhs.transform;
}
}
};

View file

@ -426,7 +426,7 @@ void LottieGroup::prepare(LottieObject::Type type)
/* Figure out if this group is a simple path drawing.
In that case, the rendering context can be sharable with the parent's. */
if (allowMerge && (child->type == LottieObject::Group || !child->mergeable())) allowMerge = false;
if (allowMerge && !child->mergeable()) allowMerge = false;
//Figure out this group has visible contents
switch (child->type) {

View file

@ -544,8 +544,7 @@ struct LottieTransform : LottieObject
bool mergeable() override
{
if (!opacity.frames && opacity.value == 255) return true;
return false;
return true;
}
LottieProperty* property(uint16_t ix) override