mirror of
https://github.com/thorvg/thorvg.git
synced 2025-06-08 13:43:43 +00:00
Update CONTRIBUTING.md
++ self-test & verification
This commit is contained in:
parent
b299157123
commit
5abcb19e6c
1 changed files with 29 additions and 14 deletions
|
@ -12,12 +12,30 @@ Hermet Park (hermet) is the lead maintainer but there are designated sub-module
|
||||||
<b>capi:</b> Michal Szczecinski (mihashco), Mira Grudzinska (mgrudzinska) <br />
|
<b>capi:</b> Michal Szczecinski (mihashco), Mira Grudzinska (mgrudzinska) <br />
|
||||||
<br />
|
<br />
|
||||||
|
|
||||||
|
## Self Test & Verification
|
||||||
|
After updated ThorVG code, please verify your change doesn't break the library. We suggests a unit-tests using Catch2 frameworks. You can easily run the Unit Tests with build commands as the following: <br />
|
||||||
|
<br/>
|
||||||
|
`
|
||||||
|
$meson . build -Dtests=true
|
||||||
|
`
|
||||||
|
<br />
|
||||||
|
`
|
||||||
|
$ninja -C build test
|
||||||
|
`
|
||||||
|
<br/>
|
||||||
|
<br/>
|
||||||
|
Please make it sure running all tests and no any Fail cases.<br/>
|
||||||
|
<br/>
|
||||||
|
Expected Fail: 0<br/>
|
||||||
|
Fail: 0<br/>
|
||||||
|
Unexpected Pass: 0<br/>
|
||||||
|
Skipped: 0<br/>
|
||||||
|
Timeout: 0<br/>
|
||||||
|
<br/>
|
||||||
## Commit Message
|
## Commit Message
|
||||||
[Module][Feature]: [Title]
|
[Module][Feature]: [Title]
|
||||||
|
|
||||||
[Description]
|
[Description]
|
||||||
##
|
|
||||||
|
|
||||||
- [Module] is a sub module majorly affected by your change. Most of times this indicates a sub folder name.
|
- [Module] is a sub module majorly affected by your change. Most of times this indicates a sub folder name.
|
||||||
This indicates whom need to review your patch as well.
|
This indicates whom need to review your patch as well.
|
||||||
|
@ -84,7 +102,4 @@ You can keep the file name, but don't please contain any prefix(tvg) nor suffix(
|
||||||
- Assignees: You
|
- Assignees: You
|
||||||
- Labels: Patch Purpose
|
- Labels: Patch Purpose
|
||||||
- CODING STYLE CHECK: Must be perfect
|
- CODING STYLE CHECK: Must be perfect
|
||||||
<p align="center">
|
<p align="center"><img width="1000" height="733" src="https://github.com/Samsung/thorvg/blob/master/res/contribution.png"></p>
|
||||||
<img width="1000" height="733" src="https://github.com/Samsung/thorvg/blob/master/res/contribution.png">
|
|
||||||
</p>
|
|
||||||
|
|
||||||
|
|
Loading…
Add table
Reference in a new issue