git_clone/thorvg
1
0
Fork 0
mirror of https://github.com/thorvg/thorvg.git synced 2025-06-21 23:41:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5
1913 commits 39 branches 105 tags 408 MiB
Commit graph

780 commits

Author SHA1 Message Date
Hermet Park
7956a21fc2 sw_engine: fix the dead lock issue. 
fully recovered from the scene clipping multi-tasksing.

@Issue: https://github.com/thorvg/thorvg/issues/1430
 2023-05-09 15:56:30 +09:00
Mira Grudzinska
52260067e4 common: changed a returned value from load function 
In the event that malloc returns a nullptr while copying
loaded raw data, a Result::NonSupport value is returned.
However, it appears that Result::FailedAllocation would be
more accurate.
 2023-05-09 15:54:20 +09:00
Mira Grudzinska
cfead5ff68 sw_renderer: fixing names after refactor 
the 'buffer' doesn't exist any more in the Surface
struct. Replaced by tjhe 'buf32' - error visible
only while avx and neon rendering supported.
 2023-05-08 22:04:01 +09:00
Hermet Park
3376f44de5 sw_engine: ++8bit grayscale rasterizer. 
These rasterizers are added for 8bit maskings.
 2023-05-08 10:55:03 +09:00
Hermet Park
4893746eb2 sw_engine: code refactoring 
use shorter name.
 2023-05-08 10:55:03 +09:00
Hermet Park
da6216f9bf sw_engine: specify buffer size so that we can clearly access the buffer data. 
Also, it introduces the 'pixel_t' type to ensure that anonymous pixel data
follows the system's decision.
 2023-05-08 10:55:03 +09:00
Hermet Park
f18d2557e3 sw_engine raster: code refactoring. 
Move partial region in rasterClear()
 2023-05-08 10:55:03 +09:00
Hermet Park
527b1af926 common sw_engine: applied colorspace format size. 
Now backend engines know which channel size is required for
compositions.

@Issue: https://github.com/thorvg/thorvg/issues/976
 2023-05-08 10:55:03 +09:00
Hermet Park
e3f363fea7 common render: added a new type for one byte pixel data. 
This is designed using for masking buffers.

@Issue: https://github.com/thorvg/thorvg/issues/976
 2023-05-08 10:55:03 +09:00
Hermet Park
01b26c43a6 engine: add Renderer::colorSpace() interface 
This is necessary for acquiring current format size.

@Issue: https://github.com/thorvg/thorvg/issues/976
 2023-05-08 10:55:03 +09:00
Hermet Park
1302c18f28 common sw_engine: polished code 
--OOM handling
++exception handling
++log info
 2023-05-08 10:55:03 +09:00
Hermet Park
3c8a4afaa7 sw_engine: fix the broken scene clipping. 
The implementation has been reverted by https://github.com/thorvg/thorvg/issues/1409

Since the sanitizer is not matured fully and it's false positive as far as I figured,
We revert the scene clipping part.

@Issue: https://github.com/thorvg/thorvg/issues/524
 2023-05-06 19:22:21 +09:00
Hermet Park
d7eb913741 sw_engine: fix a logical wrong. 
the value should be updated properly.
 2023-05-06 15:14:11 +09:00
Hermet Park
cc1f86e719 canvas: ++ log msg for dev 2023-05-05 15:52:41 +09:00
Hermet Park
e8eef1af1d common taskscheduler: revert 4db25db962 
There is a report of the thread sanitizer.
It could be a false-positive as far as I reviewed,
but we hate to be bothered by it. So let's revert it.

@Issue: https://github.com/thorvg/thorvg/issues/1409
 2023-05-04 13:42:50 +09:00
Mira Grudzinska
21ac44d120 common: fixing log std stream 
By mistake, stdout was switched to stderr
for logs. Fixed.
 2023-05-04 09:50:33 +09:00
Hermet Park
bc7b448c01 sw_engine: ++thread-safety 
One more regression bug by afea40a947

As tasks will now be triggered by other tasks on the worker threads,
the designated memory pool data (outline) for each thread should be
reset before moving on to other tasks.

@Issue: https://github.com/thorvg/thorvg/issues/1409
 2023-04-30 20:28:12 +09:00
Hermet Park
e9b12aa9f7 engine/loaders: Migrate alpha premultiplying to the engine side. 
It's not efficient to handle alpha premultiplying in every loader.
The backend engine should be responsible for it.
Now, we can remove duplicate code.
 2023-04-29 12:37:09 +09:00
Hermet Park
9fb66973f0 common picture: tiny optimization. 
Currently Picture doesn't allow to change the image source.
Thus reloading is not non-sense.
 2023-04-28 15:27:53 +09:00
Hermet Park
c710af2560 loaders: Remove the color space conversion on the loader side. 
Now, the job is completely delegated to the backend engine.
 2023-04-28 15:27:53 +09:00
Hermet Park
b733030357 sw_engine: supports the color space conversion. 
Currently implements only the necessary functions for converting
between ARGB and ABGR.

Now conversion can be accelerated by the backend engines.
 2023-04-28 15:27:53 +09:00
Hermet Park
cf4484c1ad engine/loaders: develop the ColorSpace feature infrastructure 
Replace the existing fragile usage of the colorspace data type
with a new and robust concrete ColorSpace type.
 2023-04-28 15:27:53 +09:00
Hermet Park
84012651cc common engine: code refactoring 
Introduce the RenderMesh structure to reduce the number of required parameters.
 2023-04-27 10:16:12 +09:00
Hermet Park
6d08586883 common engine: code refactoring 
Unify renderImage and renderImageMesh and hide their routines in backends.
 2023-04-27 10:16:12 +09:00
Hermet Park
8a67bff7c9 common: code refactoring 
Use own bit operation helper.
 2023-04-26 11:15:48 +09:00
Hermet Park
ac8d0018b5 common taskscheduler: fix a potential crash issue. 
Guarantee the tasks are not deleted until the taskscheduler finished them.

@Issue: https://github.com/thorvg/thorvg/issues/1370
 2023-04-26 00:23:03 +09:00
Hermet Park
20466ea78f sw_engine rle: The out-of-range memory access has been fixed. 
@Issue: https://github.com/thorvg/thorvg/issues/1370
 2023-04-26 00:23:03 +09:00
Hermet Park
7e3380db8b sw_engine mempool: fixed to address a potential memory corruption issue. 
The previous memory pool was being shared by both the main and first threads,
which could lead to corruption if any threading changes occurred.

@Issue: https://github.com/thorvg/thorvg/issues/1370
 2023-04-26 00:23:03 +09:00
Hermet Park
92dbc8507e common: polished the log message. 
Removed 'l.'. It just bothers in reading numbers.
 2023-04-25 14:23:23 +09:00
Hermet Park
aa915ee1c4 Make it silent MSVC's trivial compilation warnings. 
@Issue: https://github.com/thorvg/thorvg/issues/1381
 2023-04-21 08:28:56 +09:00
Mira Grudzinska
69a9583354 common: order(bool strokeFirst) api introduced 
The new api is introduced to handle the rendering
order of a stroke and a fill. By default fill is
rendered as the first one, stroke as the second
one. This order can be reversed by calling
order(true).

@Issue: https://github.com/thorvg/thorvg/issues/1340
 2023-04-18 22:21:55 +09:00
Hermet Park
bd695c6631 sw_engine rle: fix RLE intersect. 
IntersectSpansRegion() wasn't working correctly,
as it didn't take care of some corner cases.

This fix makes the algorithm more accurate.
 2023-04-16 22:03:36 +09:00
Hermet Park
b26672a1f6 sw_engine: support Scene ClipPath behavior. 
Introduced SceneTask, it implements scene clippath behavior
by merging RLE of the scene children render data on any running thread.

Co-authored-by: Michal Szczecinski <m.szczecinsk@partner.samsung.com>

@Issue: https://github.com/thorvg/thorvg/issues/524
 2023-04-16 22:03:36 +09:00
Hermet Park
a45275b779 sw_engine renderer: add clip() interface. 
As there are multiple types of painting tasks,
the clip() interface has been newly designed to handle clipping behavior
according to each task's role when requested."

Now Scene clipper could implement clipping behavior on it.
 2023-04-16 22:03:36 +09:00
Hermet Park
352539fe8e common paint: prevent fastrack except Shapes. 
Use fasttrack only for Shape types, as it is suitable for them.
It is not recommended to use it for other types.
 2023-04-14 20:07:04 +09:00
Hermet Park
b018c83e93 common picture: reset data properly. 
either way the render data should be reset.
 2023-04-14 20:06:46 +09:00
Hermet Park
033a65b560 common: code refactoring 
trivial changes to utilize RenderData type.
 2023-04-14 20:06:39 +09:00
Mira Grudzinska
4f3b718c3f
common: adding [E]/[L] markers to errors/logs (#1365) 
common: adding [E]/[L] markers to errors/logs

@Issue: https://github.com/thorvg/thorvg/issues/1351
 2023-04-14 09:38:01 +09:00
Mira Grudzinska
0a3718f923 common: enhancement++ of the logging method 
Logging tags are marked with the corresponding
log type color, the file and the line information
in gray, and the message content in the default
color.

@Issue: https://github.com/thorvg/thorvg/issues/1351
 2023-04-14 09:26:27 +09:00
Mira Grudzinska
54cfd45165 common: enhancement of the logging method 
Introducing colors for various log types.
For error messages, the file name and line
number are now included.

@Issue: https://github.com/thorvg/thorvg/issues/1351
 2023-04-12 20:46:04 +09:00
Mira Grudzinska
b866ee9cac common taskscheduler: warning removed 2023-04-11 11:44:05 +09:00
Hermet Park
afea40a947 common taskscheduler: increase thread efficiency. 
Revise the logic to avoid potential blocking of the main thread.
Move the clippers job completion to worker-threads to prevent main thread blocks
and enhance maximum parallelization efficiency.
 2023-04-09 13:21:29 +09:00
Hermet Park
5112bdb805 common: ++todo 2023-04-07 18:28:17 +09:00
Hermet Park
084e78d98d common: code refactoring for the IteractorAccessor. 
The instantiation of the accessor is unnecessary
as it does not require any internal context.

Simplifying its usage would be beneficial.
 2023-04-07 18:24:24 +09:00
Hermet Park
daecef5acd sw_engine: fix the inproper stroke raster. 
We have an incorrect value comparison when the stroke corner center
is adjusted. All coordinates in the stroke raster have been scaled by
the given values (sx, sy), while the stroke width remains at its
original size due to it not being clear how it should be scaled.

This brings wierd rendering results at times. Now fix it.

@Issue: https://github.com/thorvg/thorvg/issues/1336
 2023-04-07 11:43:32 +09:00
Mira Grudzinska
7b90d61e71 picture: remove unnecessary reloads 
After #1338 is applied there is no need to reload
the pictures while aksing about its viewbox or its size.
 2023-04-02 01:04:28 +09:00
Mira Grudzinska
f65d410b9f sw_engine: fix safety check 
An incorrect check introduced in bf07eb11f2
as a solution of the #1327 issue. As a consequence rotated images
were not drawn. Fixed.
 2023-03-26 12:46:28 +09:00
Hermet Park
5ebde2c9b6 common/accessor: fix uninitialized field. 
--warnings.
 2023-03-25 10:59:09 +09:00
Mira Grudzinska
9e8980a1f7 svg_loader: handling svgs without viewBox/viewPort 
Additionally:
- cases of inforrect viewBox values are handled
- cases of zero width/height of a viewBox and/or viewPort

@Issue: https://github.com/Samsung/thorvg/issues/1239
 2023-03-21 11:11:45 +09:00
Hermet Park
c9657e3e68 sw_engine - ++safety 
Prevent any potential crash.

@Issues: https://github.com/thorvg/thorvg/issues/1327
 2023-03-14 23:52:07 +09:00